[
https://issues.apache.org/jira/browse/ZOOKEEPER-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311345#comment-15311345
]
Patrick Hunt commented on ZOOKEEPER-2420:
-----------------------------------------
Hm. I'm trying to understand why is this just showing up now, given the
severity of the problem (fwiw I believe we should make this a blocker). iirc
this code has been in place forever, even before "autopurge" existed - it was
used for the external "clean" mechanism. It seems unusual that this is just
cropping up now - why?
One reason I can think of, is it related to the fact that sending of diffs was
fixed around 3.4.(6?) timeframe? ([~fpj]?)
Does the test fail w/o the fix? In the sense, does the test recreate the
situation you are trying fix in this jira.
> Autopurge deletes log file prior to oldest retained snapshot even though
> restore may need it
> --------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2420
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2420
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Reporter: Ed Rowe
> Assignee: Ed Rowe
> Attachments: ZOOKEEPER-2420.patch, ZOOKEEPER-2420.patch_v2,
> ZOOKEEPER-2420.patch_v3
>
>
> Autopurge retains all log files whose zxid are >= the zxid of the oldest
> snapshot file that it is going to retain (in PurgeTxnLog
> retainNRecentSnapshots()). Given that loading the database from
> snapshots/logs will start with the log file _prior_ to the snapshot's zxid,
> autopurge should retain the log file prior to the oldest retained snapshot as
> well, unless it verifies that it contains no zxids beyond what the snapshot
> contains.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
