[
https://issues.apache.org/jira/browse/ZOOKEEPER-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342952#comment-15342952
]
Hadoop QA commented on ZOOKEEPER-2019:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12670891/ZOOKEEPER-2019-v3.patch
against trunk revision 1748630.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3220//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3220//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3220//console
This message is automatically generated.
> Unhandled exception when setting invalid limits data in
> /zookeeper/quota/some/path/zookeeper_limits
> ----------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2019
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Reporter: Raul Gutierrez Segales
> Assignee: Raul Gutierrez Segales
> Fix For: 3.6.0, 3.5.3
>
> Attachments: ZOOKEEPER-2019-v2.patch, ZOOKEEPER-2019-v3.patch,
> ZOOKEEPER-2019-ver1.patch, ZOOKEEPER-2019.patch, ZOOKEEPER-2019.patch
>
>
> If you have quotas properly set for a given path, i.e.:
> {noformat}
> create /zookeeper/quota/test/zookeeper_limits 'count=1,bytes=100'
> create /zookeeper/quota/test/zookeeper_stats 'count=1,bytes=100'
> {noformat}
> and then you update the limits znode with bogus data, i.e.:
> {noformat}
> set /zookeeper/quota/test/zookeeper_limits ''
> {noformat}
> you'll crash the cluster because IllegalArgumentException isn't handled when
> dealing with quotas znodes:
> https://github.com/apache/zookeeper/blob/ZOOKEEPER-823/src/java/main/org/apache/zookeeper/server/DataTree.java#L379
> https://github.com/apache/zookeeper/blob/ZOOKEEPER-823/src/java/main/org/apache/zookeeper/server/DataTree.java#L425
> We should handle IllegalArgumentException. Optionally, we should also throw
> BadArgumentsException from PrepRequestProcessor.
> Review Board: https://reviews.apache.org/r/25968/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
