[ https://issues.apache.org/jira/browse/ZOOKEEPER-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342955#comment-15342955 ]
Hadoop QA commented on ZOOKEEPER-2031: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12668943/ZOOKEEPER-2031-Additional.patch against trunk revision 1748630. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3224//console This message is automatically generated. > Support tagging a QuorumServer > ------------------------------ > > Key: ZOOKEEPER-2031 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2031 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Reporter: some one > Assignee: some one > Fix For: 3.6.0, 3.5.3 > > Attachments: ZOOKEEPER-2031-Additional.patch, ZOOKEEPER-2031.patch > > > Currently ZooKeeper only allows using the server id which is an integer for > identifying servers. For my (unavoidable) use case, there may be concurrent > dynamic removes and adds of servers which may eventually have id collisions. > When this occurs, there is no good way to determine if the server (given an > id collision) that we want to remove is the right server. > To support my use case, I propose that we add a tag field to the server > string. > For my specific use case, this tag field will be used to store a uuid as a > string. > So for example: > server.1=127.0.0.1:1234:1236:participant;0.0.0.0:1237;743b9d23-85cb-45b1-8949-930fdabb21f0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)