----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49112/#review139890 -----------------------------------------------------------
Ship it! lgtm. - Patrick Hunt On June 23, 2016, 10:17 p.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49112/ > ----------------------------------------------------------- > > (Updated June 23, 2016, 10:17 p.m.) > > > Review request for zookeeper. > > > Bugs: ZOOKEEPER-1898 > https://issues.apache.org/jira/browse/ZOOKEEPER-1898 > > > Repository: zookeeper-git > > > Description > ------- > > zookeeper-cli always return "0" as exit code > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/ZooKeeperMain.java f722693 > src/java/main/org/apache/zookeeper/cli/AddAuthCommand.java e488745 > src/java/main/org/apache/zookeeper/cli/CliCommand.java 527a19e > src/java/main/org/apache/zookeeper/cli/CliException.java PRE-CREATION > src/java/main/org/apache/zookeeper/cli/CliParseException.java PRE-CREATION > src/java/main/org/apache/zookeeper/cli/CliWrapperException.java > PRE-CREATION > src/java/main/org/apache/zookeeper/cli/CloseCommand.java 1d96639 > src/java/main/org/apache/zookeeper/cli/CommandNotFoundException.java > PRE-CREATION > src/java/main/org/apache/zookeeper/cli/CreateCommand.java cc96939 > src/java/main/org/apache/zookeeper/cli/DelQuotaCommand.java 2043f47 > src/java/main/org/apache/zookeeper/cli/DeleteAllCommand.java badf5b7 > src/java/main/org/apache/zookeeper/cli/DeleteCommand.java 4714be5 > src/java/main/org/apache/zookeeper/cli/GetAclCommand.java e646a04 > src/java/main/org/apache/zookeeper/cli/GetCommand.java 0ec8270 > src/java/main/org/apache/zookeeper/cli/GetConfigCommand.java 8c6a4f5 > src/java/main/org/apache/zookeeper/cli/ListQuotaCommand.java 907c466 > src/java/main/org/apache/zookeeper/cli/Ls2Command.java 2b02583 > src/java/main/org/apache/zookeeper/cli/LsCommand.java 43099b8 > src/java/main/org/apache/zookeeper/cli/MalformedCommandException.java > PRE-CREATION > src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java 282af55 > src/java/main/org/apache/zookeeper/cli/RemoveWatchesCommand.java f63cf0f > src/java/main/org/apache/zookeeper/cli/SetAclCommand.java f27446c > src/java/main/org/apache/zookeeper/cli/SetCommand.java 1c39377 > src/java/main/org/apache/zookeeper/cli/SetQuotaCommand.java 873c6d2 > src/java/main/org/apache/zookeeper/cli/StatCommand.java e5cfe54 > src/java/main/org/apache/zookeeper/cli/SyncCommand.java c12d35d > src/java/test/org/apache/zookeeper/ZooKeeperTest.java 574eab0 > > Diff: https://reviews.apache.org/r/49112/diff/ > > > Testing > ------- > > > Thanks, > > Abraham Fine > >
