[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416640#comment-15416640
 ] 

Arshad Mohammad commented on ZOOKEEPER-2238:
--------------------------------------------

Thanks [~eribeiro] for working on this feature.
As I earlier said:
Use system property zookeeper.maxCnxns to avoid so many constructor and method 
signature change.Focus is getting lost from actual work.
NOTE: User will configure maxCnxns=somevalue in zoo.cfg and it will be read as 
zookeeper.maxCnxns in ZooKeeper system. So need not be configure as 
-Dzookeeper.maxCnxns in some script

I Know maxCnxns and maxClientCnxns are related. But we are implementing 
maxCnxns now. We should implement it in correct way.
May be we can raise another jira to correct the maxClientCnxns implementation.
*ZooKeeper is already very rigid for modification. If we keep modifying 
existing constructor and method signatures for every new properly we introduce 
in the zookeeper then ZooKeeper would become even more rigid for modification.*

What you say [~rgs],[~fpj].
Let me know if more clarity is required I can submit a patch.

> Support limiting the maximum number of connections/clients to a zookeeper 
> server.
> ---------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2238
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2238
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: nijel
>            Assignee: Edward Ribeiro
>         Attachments: ZOOKEEPER-2238.2.patch, ZOOKEEPER-2238.3.patch, 
> ZOOKEEPER-2238.4.patch, ZOOKEEPER-2238.diff
>
>
> Currently zookeeper have the feature of limiting the maximum number of 
> connection/client  per IP or Host (maxClientCnxns).
> But to safe guard zookeeper server from DoS attack due to many clients from 
> different IPs,  it is better to have a limit of total number of 
> connections/clients to a a single member of the ZooKeeper ensemble as well.
> So the idea is to introduce a new configuration to limit the maximum number 
> of total connections/clients.
> Please share your thoughts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to