[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419126#comment-15419126
 ] 

Hadoop QA commented on ZOOKEEPER-2504:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12823500/ZOOKEEPER-2504.patch
  against trunk revision 1755857.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 2 new Findbugs (version 2.0.3) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3360//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3360//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3360//console

This message is automatically generated.

> Enforce that server ids are unique in a cluster
> -----------------------------------------------
>
>                 Key: ZOOKEEPER-2504
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2504
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Dan Benediktson
>            Assignee: Dan Benediktson
>         Attachments: ZOOKEEPER-2504.patch
>
>
> The leader will happily accept connections from learners that have the same 
> server id (i.e., due to misconfiguration). This can lead to various issues 
> including non-unique session_ids being generated by these servers.
> The leader can enforce that all learners come in with unique server IDs; if a 
> learner attempts to connect with an id that is already in use, it should be 
> denied.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to