[
https://issues.apache.org/jira/browse/ZOOKEEPER-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494531#comment-15494531
]
Michael Han commented on ZOOKEEPER-2509:
----------------------------------------
[~yufeldman], latest patch change to NettyServerCnxn.java looks good.
Small issues on test case:
* Would be good to clear properties in tearDown.
* Remove these unrelated comments in test:
{noformat}
// Reset to default value since some test cases set this to true.
// Needed for JDK7 since unit test can run is random order
{noformat}
and
{noformat}
/**
* Verify that we get all of the events we expect to get. This particular
* case verifies that we see all of the data events on a particular node.
* There was a bug (ZOOKEEPER-137) that resulted in events being dropped
* in some cases (timing).
*
* @throws IOException
* @throws InterruptedException
* @throws KeeperException
*/
{noformat}
I believe these comments were copied from WatherTest and later forgot to be
removed.
> Secure mode leaks memory
> ------------------------
>
> Key: ZOOKEEPER-2509
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2509
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.1, 3.5.2
> Reporter: Ted Dunning
> Assignee: Ted Dunning
> Fix For: 3.5.3, 3.6.0
>
> Attachments:
> 0001-Updated-patch-for-Netty-leak-testing-to-trunk.patch,
> ZOOKEEPER-2509.patch, ZOOKEEPER-2509.patch, ZOOKPEEPER-2509.patch,
> leak-patch.patch
>
>
> The Netty connection handling logic fails to clean up watches on connection
> close. This causes memory to leak.
> I will have a repro script available soon and a fix. I am not sure how to
> build a unit test since we would need to build an entire server and generate
> keys and such. Advice on that appreciated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
