[
https://issues.apache.org/jira/browse/ZOOKEEPER-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494580#comment-15494580
]
Edward Ribeiro edited comment on ZOOKEEPER-2579 at 9/16/16 1:27 PM:
--------------------------------------------------------------------
{quote}
I guess it would be reasonable to say that the tests that I wrote are more like
integration tests while the tests that you attached are true unit tests. I
guess it could be argued that most of the tests in ZooKeeperServerMainTest are
really integration tests.
{quote}
Yup, I agree.
{quote}
It would be possible to include both types of test instead of needing to
choose. What do you think?
{quote}
Sounds good to me. In fact, it's up to you leave the
{{FileTxnSnapLogTest.java}} or not. :) Let's see what the committers say, but I
am okay with either approach, at first.
*By the way, thanks for pointing out {{testWithoutAutoCreateDataLogDir}}
because it reminded me that it would be nice to include the timeout (i.e.,
{{@Test(timeout = 30000)}}) in those kind of tests. Please, update your patch
accordingly. ;)*
Best regards,
was (Author: eribeiro):
{quote}
I guess it would be reasonable to say that the tests that I wrote are more like
integration tests while the tests that you attached are true unit tests. I
guess it could be argued that most of the tests in ZooKeeperServerMainTest are
really integration tests.
{quote}
Yup, I agree.
{quote}
It would be possible to include both types of test instead of needing to
choose. What do you think?
{quote}
Sounds good to me. In fact, it's up to you leave the
{{FileTxnSnapLogTest.java}} or not. :) Let's see what the committers say, but I
am okay with either approach, at first.
By the way, thanks for pointing out
{{ZooKeeperServerMainTest.testWithoutAutoCreateDataLogDir}} because it reminded
me that it would be nice to include the timeout (i.e., {{@Test(timeout =
30000)}}) in those kind of tests.
Best regards,
> ZooKeeper server should verify that dataDir and snapDir are writeable before
> starting
> -------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2579
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2579
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.9, 3.5.2
> Reporter: Abraham Fine
> Assignee: Abraham Fine
> Fix For: 3.4.10, 3.5.3
>
> Attachments: FileTxnSnapLogTest.java, ZOOKEEPER-2579.patch,
> ZOOKEEPER-2579_3.4.patch
>
>
> If the directories specified for the dataDir or the snapDir are not
> writeable, the server does not fail until it actually tries to write there.
> It should fail when it starts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
