[
https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545650#comment-15545650
]
ASF GitHub Bot commented on ZOOKEEPER-1525:
-------------------------------------------
GitHub user Randgalt opened a pull request:
https://github.com/apache/zookeeper/pull/84
[ZOOKEEPER-1525] Plumb ZooKeeperServer object into auth plugins
Based on patch work from
https://issues.apache.org/jira/browse/ZOOKEEPER-1525
Created ServerAuthenticationProvider which has a method to accept the
ZooKeeper
server so that auth can be done using values in the ZK database. As this is
a new
interface, existing implementations aren't affected helping backward
compatibility
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Randgalt/zookeeper ZOOKEEPER-1525
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
----
commit 4de95483cb624217e2f3cd63872e23d60f28749b
Author: randgalt <jor...@jordanzimmerman.com>
Date: 2016-10-04T15:23:30Z
Based on patch work from
https://issues.apache.org/jira/browse/ZOOKEEPER-1525
Created ServerAuthenticationProvider which has a method to accept the
ZooKeeper
server so that auth can be done using values in the ZK database. As this is
a new
interface, existing implementations aren't affected helping backward
compatibility
----
> Plumb ZooKeeperServer object into auth plugins
> ----------------------------------------------
>
> Key: ZOOKEEPER-1525
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1525
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.5.0
> Reporter: Warren Turkal
> Assignee: Tim Crowder
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch,
> ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch,
> ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch
>
>
> I want to plumb the ZooKeeperServer object into the auth plugins so that I
> can store authentication data in zookeeper itself. With access to the
> ZooKeeperServer object, I also have access to the ZKDatabase and can look up
> entries in the local copy of the zookeeper data.
> In order to implement this, I make sure that a ZooKeeperServer instance is
> passed in to the ProviderRegistry.initialize() method. Then initialize() will
> try to find a constructor for the AuthenticationProvider that takes a
> ZooKeeperServer instance. If the constructor is found, it will be used.
> Otherwise, initialize() will look for a constructor that takes no arguments
> and use that instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
