[
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547752#comment-15547752
]
Rakesh R edited comment on ZOOKEEPER-1045 at 10/5/16 7:08 AM:
--------------------------------------------------------------
Attached another patch in the [review ticket
47354|https://reviews.apache.org/r/47354/] addressing [~hanm]'s comments.
Majorly I've used the {{QuorumConnectionThread}} only if the
'quorumSaslEnabled' to process the connection requests asynchronously. In the
existing code path(non-auth) it will continue connecting to the peers
sequentially. This separation is basically done to give the confidence to all
by not touching the existing code flow, and keeps a different code path for
this feature. I hope this change will help to push the feature safely in
{{branch3.4}}.
[~fpj], [~cnauroth], [~rgs], do you have some cycles to review the latest
patch. Appreciate your feedback. Thanks!
was (Author: rakeshr):
Attached another patch in the [review ticket
47354|https://reviews.apache.org/r/47354/] addressing [~hanm]'s comments.
Majorly I've used the {{QuorumConnectionThread}} only if the
'quorumSaslEnabled' to process the connection requests asynchronously. In the
existing code path(non-auth) it will continue connecting to the peers
sequentially. This change is basically done to give the confidence to all by
not touching the existing code flow so as to improve the confidence in pushing
this feature in.
[~fpj], [~cnauroth], [~rgs], do you have some cycles to review the latest
patch. Appreciate your feedback. Thanks!
> Support Quorum Peer mutual authentication via SASL
> --------------------------------------------------
>
> Key: ZOOKEEPER-1045
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Eugene Koontz
> Assignee: Rakesh R
> Priority: Critical
> Fix For: 3.4.10, 3.5.3
>
> Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch,
> 1045_failing_phunt.tar.gz, HOST_RESOLVER-ZK-1045.patch,
> TEST-org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.txt,
> ZK-1045-test-case-failure-logs.zip, ZOOKEEPER-1045-00.patch,
> ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf,
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch,
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch,
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch,
> ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch,
> ZOOKEEPER-1045TestValidationDesign.pdf,
> org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest.testRollingUpgrade.log
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers.
> This bug, on the other hand, is for authentication among quorum peers.
> Hopefully much of the work done on SASL integration with Zookeeper for
> ZOOKEEPER-938 can be used as a foundation for this enhancement.
> Review board: https://reviews.apache.org/r/47354/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
