[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560489#comment-15560489
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-2608:
---------------------------------------------------

quick pass and some nits:

{code}
+        if ( hasT && hasE ) {
+            throw new MalformedCommandException("TTLs cannot be used with 
Ephemeral znodes");
+        }
+        if ( hasT && hasC ) {
+            throw new MalformedCommandException("TTLs cannot be used with 
Container znodes");
+        }
+
{code}

extra whitespaces around the conditions (doesn't match that file's coding 
sytle).

{code}
+        if ( hasT ) {
+            try {
+                EphemeralType.ttlToEphemeralOwner(ttl);
+            } catch (IllegalArgumentException e) {
+                throw new MalformedCommandException(e.getMessage());
+            }
{code}

ditto.

> Create CLI option for TTL ephemerals
> ------------------------------------
>
>                 Key: ZOOKEEPER-2608
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2608
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: c client, java client, jute, server
>            Reporter: Camille Fournier
>            Assignee: Jordan Zimmerman
>             Fix For: 3.6.0
>
>         Attachments: ZOOKEEPER-2608-2.patch, ZOOKEEPER-2608.patch
>
>
> Need to update CreateCommand to have the TTL node option



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to