----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/#review154230 -----------------------------------------------------------
src/java/main/org/apache/zookeeper/ZooKeeper.java (line 224) <https://reviews.apache.org/r/51546/#comment223725> I think, it is not required to increase the visibility to 'public', instead this could be 'protected', right? Similarly there are few more visibility changes to functions, variables etc. Could you please revisit all these and do approriate changes to the visibility. src/java/main/org/apache/zookeeper/admin/ZooKeeperAdmin.java (line 47) <https://reviews.apache.org/r/51546/#comment223730> Please add "@since 3.5.3" at the class level javadoc, that would convey the timeline clearly. src/java/main/org/apache/zookeeper/server/DataTree.java (line 261) <https://reviews.apache.org/r/51546/#comment223722> Please use {} instead of string concatenation. src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java (line 110) <https://reviews.apache.org/r/51546/#comment223727> Many places its using deprecated APIs. Please visit all such occurances and replace with new API. Assert.assertTrue(e.getCode() == KeeperException.Code.NoAuth); replace with Assert.assertTrue(e.code() == KeeperException.Code.NOAUTH); - Rakesh R On Oct. 18, 2016, 5:15 a.m., Michael Han wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51546/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 5:15 a.m.) > > > Review request for zookeeper, fpj, Patrick Hunt, Raul Gutierrez Segales, and > Alexander Shraer. > > > Bugs: ZOOKEEPER-2014 > https://issues.apache.org/jira/browse/ZOOKEEPER-2014 > > > Repository: zookeeper-git > > > Description > ------- > > Address various security concerns around reconfig feature (ZOOKEEPER-2014) to > unblock 3.5.3 release. > > > Diffs > ----- > > build.xml 5328035 > src/c/include/zookeeper.h 18a203d > src/c/tests/TestReconfigServer.cc 6a429ac > src/c/tests/ZooKeeperQuorumServer.h aa8b7cc > src/c/tests/ZooKeeperQuorumServer.cc 23392cd > src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 5a30da8 > src/docs/src/documentation/content/xdocs/zookeeperReconfig.xml 7168a01 > src/java/main/org/apache/zookeeper/ClientCnxn.java 12dd51c > src/java/main/org/apache/zookeeper/KeeperException.java a05f1ab > src/java/main/org/apache/zookeeper/ZooKeeper.java 1c9ed4e > src/java/main/org/apache/zookeeper/ZooKeeperMain.java 25d61a4 > src/java/main/org/apache/zookeeper/admin/ZooKeeperAdmin.java PRE-CREATION > src/java/main/org/apache/zookeeper/cli/CliCommand.java 3d0a90b > src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java deb7914 > src/java/main/org/apache/zookeeper/server/DataTree.java 4666578 > src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 7a72757 > src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java > 25b682b > src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java e275f9c > src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java fc6766c > src/java/main/org/apache/zookeeper/server/SnapshotFormatter.java f94c54d > src/java/main/org/apache/zookeeper/server/ZKDatabase.java 05bbb91 > src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java d4f150b > src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 885a5e1 > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 68bef42 > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > e772fa8 > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java > bfe8588 > src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java 109c1b5 > src/java/test/org/apache/zookeeper/TestableZooKeeper.java 4d46fdf > src/java/test/org/apache/zookeeper/server/CRCTest.java da4ebaf > src/java/test/org/apache/zookeeper/server/DataTreeTest.java d726643 > src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java 87aa73e > src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java > 1030209 > src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > c6ee230 > src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java > cc44243 > src/java/test/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java > 95e5e53 > src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 4debe74 > src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTest.java > fae7e5b > src/java/test/org/apache/zookeeper/server/quorum/RaceConditionTest.java > ef7f3df > src/java/test/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java > 241af52 > > src/java/test/org/apache/zookeeper/server/quorum/ReconfigDuringLeaderSyncTest.java > 301837d > > src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCasesTest.java > e7147b3 > src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java > ee9f2e2 > > src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java > 1f6ce1f > src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 6a01447 > src/java/test/org/apache/zookeeper/test/ACLTest.java 9920fc4 > src/java/test/org/apache/zookeeper/test/ClientBase.java 309b2b2 > src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java a4244d8 > src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java 2bbf7b5 > src/java/test/org/apache/zookeeper/test/QuorumBase.java f687f45 > src/java/test/org/apache/zookeeper/test/QuorumUtil.java 314171d > src/java/test/org/apache/zookeeper/test/QuorumUtilTest.java 76e6df0 > src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java > PRE-CREATION > src/java/test/org/apache/zookeeper/test/ReconfigMisconfigTest.java > PRE-CREATION > src/java/test/org/apache/zookeeper/test/ReconfigTest.java 248a754 > src/java/test/org/apache/zookeeper/test/StandaloneTest.java 5c95280 > > Diff: https://reviews.apache.org/r/51546/diff/ > > > Testing > ------- > > > Thanks, > > Michael Han > >
