Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/98#discussion_r86483860
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
    @@ -520,6 +520,12 @@ public synchronized void setCurrentVote(Vote v){
         protected boolean quorumListenOnAllIPs = false;
     
         /**
    +     * Keeps time taken for leader election in milliseconds. Sets the 
value to
    +     * this variable only after the completion of leader election.
    +     */
    +    private long electionTimeTaken = -1;
    --- End diff --
    
    Thanks @eribeiro ,
    
    LeaderMXBean, FollowerMXBean will be available only after the quorum leader 
election and the value won't be changed until next LE. I think, adding 
'volatile' doesn't make any difference, right?
    
    code reference:
    
    
https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/Leader.java#L417
    
https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/Follower.java#L70
    
        Leader.java
            zk.registerJMX(new LeaderBean(this, zk), self.jmxLocalPeerBean);
    
        Follower.java
            fzk.registerJMX(new FollowerBean(this, zk), self.jmxLocalPeerBean);


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to