[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635085#comment-15635085
]
ASF GitHub Bot commented on ZOOKEEPER-2479:
-------------------------------------------
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/98#discussion_r86483860
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -520,6 +520,12 @@ public synchronized void setCurrentVote(Vote v){
protected boolean quorumListenOnAllIPs = false;
/**
+ * Keeps time taken for leader election in milliseconds. Sets the
value to
+ * this variable only after the completion of leader election.
+ */
+ private long electionTimeTaken = -1;
--- End diff --
Thanks @eribeiro ,
LeaderMXBean, FollowerMXBean will be available only after the quorum leader
election and the value won't be changed until next LE. I think, adding
'volatile' doesn't make any difference, right?
code reference:
https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/Leader.java#L417
https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/Follower.java#L70
Leader.java
zk.registerJMX(new LeaderBean(this, zk), self.jmxLocalPeerBean);
Follower.java
fzk.registerJMX(new FollowerBean(this, zk), self.jmxLocalPeerBean);
> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> ----------------------------------------------------------------
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
> Issue Type: Improvement
> Components: quorum
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch,
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch,
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via
> jmx Leader, Follower beans.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
