[
https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637893#comment-15637893
]
ASF GitHub Bot commented on ZOOKEEPER-2549:
-------------------------------------------
GitHub user yufeldman opened a pull request:
https://github.com/apache/zookeeper/pull/99
ZOOKEEPER-2549 Add exception handling to sendResponse
Fix for:
As NettyServerCnxn.sendResponse() allows all the exception to bubble up it
can stop main ZK requests processing thread
Same changes done for NIOServerCnxn
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yufeldman/zookeeper master2549
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/99.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #99
----
commit 18270e28f3e60a03422641dd0ee2ccaad6a3b096
Author: Yuliya Feldman <[email protected]>
Date: 2016-09-03T05:18:30Z
ZOOKEEPER-2549 Add exception handling to sendResponse
----
> As NettyServerCnxn.sendResponse() allows all the exception to bubble up it
> can stop main ZK requests processing thread
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2549
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2549
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.1
> Reporter: Yuliya Feldman
> Assignee: Yuliya Feldman
> Attachments: ZOOKEEPER-2549-2.patch, ZOOKEEPER-2549.patch,
> ZOOKEEPER-2549.patch, zookeeper-2549-1.patch
>
>
> As NettyServerCnxn.sendResponse() allows all the exception to bubble up it
> can stop main ZK requests processing thread and make Zookeeper server look
> like it is hanging, while it just can not process any request anymore.
> Idea is to catch all the exceptions in NettyServerCnxn.sendResponse() ,
> convert them to IOException and allow it propagating up
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
