Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/84 Generally looks good to me, but I have the same concern as @fpj, maybe in the future the newly added auth needs additional parameters, then we have to add another wrapper with new interface to keep the old ones backward compatible. I also agree a general metadata map is error-prone, but I think we can have a compromise solution between explicit parameters and general metadata map: Create a class (e.g. AuthData) with the explicit parameters(zks, cnxn, path, perm, setAcls) in it, which has the get and set method, and use this class in the newly added ServerAuthenticationProvider interface. In the future if we need additional parameter, we only need to change this class, no interface and backward compatible issues will be involved. What do you think @Randgalt @fpj?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---