[
https://issues.apache.org/jira/browse/ZOOKEEPER-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684450#comment-15684450
]
ASF GitHub Bot commented on ZOOKEEPER-2517:
-------------------------------------------
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/113
ZOOKEEPER-2517:jute.maxbuffer is ignored
ZOOKEEPER-2517:jute.maxbuffer is ignored
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arshadmohammad/zookeeper ZOOKEEPER-2517
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #113
----
commit d722cacd247cee4352ce4012db92cb604f8fa57b
Author: arshadmohammad <[email protected]>
Date: 2016-11-21T19:09:41Z
jute.maxbuffer is ignored
----
> jute.maxbuffer is ignored
> -------------------------
>
> Key: ZOOKEEPER-2517
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2517
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.2
> Reporter: Benjamin Jaton
> Assignee: Arshad Mohammad
> Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2517-01.patch, ZOOKEEPER-2517-02.patch,
> ZOOKEEPER-2517-03.patch, ZOOKEEPER-2517-04.patch, ZOOKEEPER-2517.patch
>
>
> In ClientCnxnSocket.java the parsing of the system property is erroneous:
> {code}packetLen = Integer.getInteger(
> clientConfig.getProperty(ZKConfig.JUTE_MAXBUFFER),
> ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT
> );{code}
> Javadoc of Integer.getInteger states "The first argument is treated as the
> name of a system property", whereas here the value of the property is passed.
> Instead I believe the author meant to write something like:
> {code}packetLen = Integer.parseInt(
> clientConfig.getProperty(
> ZKConfig.JUTE_MAXBUFFER,
> String.valueOf(ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT)
> )
> );{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
