[
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15690710#comment-15690710
]
ASF GitHub Bot commented on ZOOKEEPER-2628:
-------------------------------------------
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/102
@fpj Thank you for taking time to double check the patch.
>> I noticed that there are also unaddressed comments from @lvfangmin and
@eribeiro .
The comments were about using Interface type instead of implementation
type, and I addressed the comments by creating ZOOKEEPER-2630 because this
issue is not a regression and is not specifically about findbug warnings, and I
think it might be better to address them separately.
I've left replies on your other comments in PR, please take a look.
> Investigate and fix findbug warnings
> ------------------------------------
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.2
> Reporter: Michael Han
> Assignee: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to
> Infra team, and this leads to 20 new warnings produced by findbug. The
> warning reports can be found on [pre commit
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build
> number >= 3513. These warnings need to be triaged and fixed if they are
> legitimate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
