[
https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713597#comment-15713597
]
Michael Han commented on ZOOKEEPER-2573:
----------------------------------------
bq. I think it is better to change org.apache.zookeeper.version.Info.REVISION
from int to String and store the git revision.
+1 on the idea. [~arshad.mohammad], are you still interested working on a fix
for this issue? If so, please go ahead and submit a pull request, so we can get
this in for 3.5.3.
> Modify Info.REVISION to adapt git repo
> --------------------------------------
>
> Key: ZOOKEEPER-2573
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, server
> Reporter: Arshad Mohammad
> Fix For: 3.5.3, 3.6.0
>
>
> Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo
> revision
> Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo
> revision which is of type int
> But after migrating to git repo the git repo's revision(commit
> 63f5132716c08b3d8f18993bf98eb46eb42f80fb) can not be stored in this variable.
> So either we should modify this variable to string to introduce new variable
> to store the git revision and leave the svn revision variable unchanged.
> build.xml, and org.apache.zookeeper.version.util.VerGen also need to be
> modified.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
