Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/120#discussion_r91208138
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -165,8 +173,41 @@ public File getSnapDir() {
*/
public long restore(DataTree dt, Map<Long, Integer> sessions,
PlayBackListener listener) throws IOException {
- snapLog.deserialize(dt, sessions);
+ long deserializeResult = snapLog.deserialize(dt, sessions);
FileTxnLog txnLog = new FileTxnLog(dataDir);
+ boolean suspectEmptyDB;
+ File initFile = new File(dataDir.getParent(), "initialize");
+ if (initFile.exists()) {
+ if (!initFile.delete()) {
+ LOG.warn("Unable to delete initialization file " +
initFile.toString());
--- End diff --
It sounds pretty serious issue if the initialize file can't be cleaned up
upon startup of a new ensemble for whatever reasons as the presence of this
file is the key promise made here - not able to clean it up will possibly lead
to inconsistent quorum state again that this PR is trying to fix. So, maybe
throw an IOException here to abort server start process and let admin intervene
instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
