[
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15738490#comment-15738490
]
Hadoop QA commented on ZOOKEEPER-2642:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12842680/ZOOKEEPER-2642.patch
against trunk revision 73d6bf5353586e49740f77291d1fd98b07f916cc.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 21 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 2 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3542//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3542//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3542//console
This message is automatically generated.
> ZOOKEEPER-2014 breaks existing clients for little benefit
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client, java client
> Affects Versions: 3.5.2
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin.
> It appears this was done to document that these are methods have access
> restrictions. However, this change breaks Apache Curator (and possibly other
> clients). Curator APIs will have to be changed and/or special methods need to
> be added. A breaking change of this kind should only be done when the benefit
> is overwhelming. In this case, the same information can be conveyed with
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig()
> methods back to the ZooKeeper class with additional documentation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
