[ https://issues.apache.org/jira/browse/ZOOKEEPER-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741327#comment-15741327 ]
Hadoop QA commented on ZOOKEEPER-2391: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12800423/ZOOKEEPER-2391-3.4-3.patch against trunk revision cd0e323831c8b4cde64976325bfc79bb53cdd9b7. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3546//console This message is automatically generated. > setMin/MaxSessionTimeout of ZookeeperServer are implemented in quite a weak > way > ------------------------------------------------------------------------------- > > Key: ZOOKEEPER-2391 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2391 > Project: ZooKeeper > Issue Type: Bug > Components: server > Reporter: Kazuaki Banzai > Assignee: Kazuaki Banzai > Priority: Minor > Attachments: ZOOKEEPER-2391-2.patch, ZOOKEEPER-2391-3.4-2.patch, > ZOOKEEPER-2391-3.4-3.patch, ZOOKEEPER-2391-3.4.patch, ZOOKEEPER-2391-3.patch, > ZOOKEEPER-2391.patch > > > setMin/MaxSessionTimeout of ZookeeperServer are implemented in quite a weak > way. > * -1 restores the default, but this is not documented. > * values < -1 are permitted but make no sense. > * min > max is permitted but makes not sense. -- This message was sent by Atlassian JIRA (v6.3.4#6332)