Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/123
@yufeldman Sure, totally agree about this being a separate issue! :+1:
My only concern is that **IF** we decide to introduce this injection
framework into ZK **after merging ZOOKEEPER-2549** then some of the mocking and
reflection changes introduced by ZOOKEEPER-2549 for the purposes of testing
become redundant, so basically we would have to undo parts of it (but not the
bug fix, of course). See this PR for a concrete idea of what I am trying to say.
But you raised a very important point: **ZOOKEEPER-2549 is critical, and
delaying its merging is gonna be bad for the project release, IMHO.** So, I am
all for you keep going your work (congrats, btw) and run this as a future
issue. Or whatever the committers find more suitable. /cc @fpj @rgs1 @hanm
@phunt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
