Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r96125997
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -45,6 +45,9 @@
private int currentIndex = -1;
+ // Don't re-resolve on first next() call
+ private boolean connectedSinceNext = true;
--- End diff --
All calls to `next` and `onConnected` are from the `sendThread`. I don't
see a reason for making volatile, unless we are doing it defensively. Let me
know if I'm missing anything.
Note that this pull request is for the 3.4 branch, we need a different
patch for 3.5 and master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
