Github user jvz commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/148#discussion_r96145218
  
    --- Diff: conf/log4j2.xml ---
    @@ -0,0 +1,56 @@
    +<?xml version="1.0" encoding="UTF-8" ?>
    +<!-- All loggers are Async if
    +    
-DLog4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector
 if is set -->
    +<Configuration status="warn" strict="true">
    +  <Properties>
    +    <Property name="consoleLayoutPattern">%d{ISO8601} [myid:%X{myid}] - 
%-5p [%t:%C{1}@%L] - %m%n</Property>
    --- End diff --
    
    I'd generally advise against [enabling location 
information](http://logging.apache.org/log4j/2.x/manual/layouts.html#LocationInformation)
 by default due to performance issues. I personally don't find location 
information all that useful outside of caught exceptions anyways.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to