[ https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833861#comment-15833861 ]
ASF GitHub Bot commented on ZOOKEEPER-2573: ------------------------------------------- Github user arshadmohammad commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/137#discussion_r97247778 --- Diff: src/lastRevision.bat --- @@ -16,8 +16,9 @@ rem See the License for the specific language governing permissions and rem limitations under the License. rem Find the current revision, store it in a file, for DOS -svn info | findstr Revision > %1 +git rev-parse HEAD > %1 -For /F "tokens=1,2 delims= " %%a In (%1) Do ( - echo lastRevision=%%b> %1 +For /F "tokens=* delims= " %%a In (%1) Do ( --- End diff -- This is not working. May be you can replace with all the script with following script: for /f "delims=" %%i in ('git rev-parse HEAD') do set rev=%%i echo lastRevision=%rev% > %1 > Modify Info.REVISION to adapt git repo > -------------------------------------- > > Key: ZOOKEEPER-2573 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573 > Project: ZooKeeper > Issue Type: Bug > Components: build, server > Affects Versions: 3.4.9, 3.5.2 > Reporter: Arshad Mohammad > Assignee: Edward Ribeiro > Fix For: 3.4.10, 3.5.3, 3.6.0 > > > Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo > revision > Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo > revision which is of type int > But after migrating to git repo the git repo's revision(commit > 63f5132716c08b3d8f18993bf98eb46eb42f80fb) can not be stored in this variable. > So either we should modify this variable to string to introduce new variable > to store the git revision and leave the svn revision variable unchanged. > build.xml, and org.apache.zookeeper.version.util.VerGen also need to be > modified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)