Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r97435427
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -57,26 +62,20 @@
public StaticHostProvider(Collection<InetSocketAddress>
serverAddresses)
throws UnknownHostException {
for (InetSocketAddress address : serverAddresses) {
- InetAddress ia = address.getAddress();
- InetAddress resolvedAddresses[] =
InetAddress.getAllByName((ia!=null) ? ia.getHostAddress():
- address.getHostName());
+ InetAddress resolvedAddresses[];
+ try {
--- End diff --
I'm still not sure we should do this. I'm concerned about making that
method visible while the original intention was not to expose it. Are you aware
of any other project that has done this for `getHostString`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
