Github user rakeshadr commented on the issue: https://github.com/apache/zookeeper/pull/137 @eribeiro, Earlier with svn revision(integer value), if there is NFE while parsing arg[1] then it suppress this exception and returns -1. The outer try-catch block guards the from #parseVersionString() function. IIUC, that is reason for separate try-catch blocks. Anyway, now with the git rev hash the inner try-catch block is not needed as we are dealing with String value. I could see you have removed the inner try-catch block, that looks OK to me. Still we need to maintain the outer try-catch block where it guards MAJ, MINOR, MICRO parsing, right?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---