[
https://issues.apache.org/jira/browse/ZOOKEEPER-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15842890#comment-15842890
]
ASF GitHub Bot commented on ZOOKEEPER-2622:
-------------------------------------------
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/95
Go ahead @arshadmohammad! 😃
My only observation is that this dead code is also in branch-3.4 and
branch-3.5 so I would advise to cherry-pick it to those branches too, right
@fpj ?
> ZooTrace.logQuorumPacket does nothing
> -------------------------------------
>
> Key: ZOOKEEPER-2622
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2622
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Trivial
> Labels: newbie
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> The method simply returns and there is some code commented out:
> {code}
> // if (isTraceEnabled(log, mask)) {
> // logTraceMessage(LOG, mask, direction + " "
> // + FollowerHandler.packetToString(qp));
> // }
> {code}
> There are calls to this trace method, so I think we should fix it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
