Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/157#discussion_r98574533
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -321,13 +321,16 @@ protected void syncWithLeader(long newLeaderZxid)
throws IOException, Interrupte
QuorumPacket ack = new QuorumPacket(Leader.ACK, 0, null, null);
QuorumPacket qp = new QuorumPacket();
long newEpoch = ZxidUtils.getEpochFromZxid(newLeaderZxid);
-
- readPacket(qp);
+ //In the DIFF case we don't need to do a snapshot because the
transactions will sync on top of any existing snapshot
--- End diff --
nit: I think we generally put spaces after the //
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
