Github user eribeiro commented on the issue:

    https://github.com/apache/zookeeper/pull/160
  
    @arshadmohammad My two last questions (really!):
     
    * Is this change supposed to be applied to branch-3.4 and branch-3.5? 
    
    * I see that `DataNode.getChildren()` is called in half a dozen places with 
more or less the logic below:
    
    ```
                Set<String> childs = node.getChildren();
                if (childs != null) {
                    children = childs.toArray(new String[childs.size()]);
                }
                // children size is zero
    
               if (children != null) {
                   for (String child : children) {
                       // DO LOGIC
                   }
               }
    ```
    
    As `children` is zero length the for-each loop is not executed. I am fine 
with leaving this code as-is. Otherwise, we could remove the now useless `if 
(children != null)` calls. Wdyt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to