[ https://issues.apache.org/jira/browse/ZOOKEEPER-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853161#comment-15853161 ]
ASF GitHub Bot commented on ZOOKEEPER-2680: ------------------------------------------- GitHub user arshadmohammad opened a pull request: https://github.com/apache/zookeeper/pull/162 ZOOKEEPER-2680: Correct DataNode.getChildren() inconsistent behaviour. :branch-3.4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/arshadmohammad/zookeeper ZOOKEEPER-2680-br-3.4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/162.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #162 ---- commit 30c1d1bc89ed142975205ca7d75cd71a077b7f72 Author: Mohammad Arshad <ars...@apache.org> Date: 2017-02-05T08:10:03Z ZOOKEEPER-2680: Correct DataNode.getChildren() inconsistent behaviour. ---- > Correct DataNode.getChildren() inconsistent behaviour. > ------------------------------------------------------ > > Key: ZOOKEEPER-2680 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2680 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.4.9, 3.5.1 > Reporter: Mohammad Arshad > Assignee: Mohammad Arshad > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2680-01.patch > > > DataNode.getChildren() API returns null and empty set if there are no > children in it depending on when the API is called. DataNode.getChildren() > API behavior should be changed and it should always return empty set if the > node does not have any child > *DataNode.getChildren() API Current Behavior:* > # returns null initially > When DataNode is created and no children are added yet, > DataNode.getChildren() returns null > # returns empty set after all the children are deleted: > created a Node > add a child > delete the child > DataNode.getChildren() returns empty set. > After fix DataNode.getChildren() should return empty set in all the above > cases. -- This message was sent by Atlassian JIRA (v6.3.15#6346)