[ https://issues.apache.org/jira/browse/ZOOKEEPER-2687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859697#comment-15859697 ]
Hadoop QA commented on ZOOKEEPER-2687: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12851881/ZOOKEEPER-2687-01.patch against trunk revision 434abbbb7eef271fab02306bcc9c8ad29ec2fe2e. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3576//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3576//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3576//console This message is automatically generated. > Deadlock while shutting down the Leader server. > ----------------------------------------------- > > Key: ZOOKEEPER-2687 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2687 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.5.2, 3.6.0 > Reporter: Mohammad Arshad > Assignee: Mohammad Arshad > Fix For: 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2687-01.patch > > > Leader server enters into deadlock while shutting down. This happens some > time only. > The reason and deadlock flow is same as ZOOKEEPER-2380. > shutdown was removed from synchronized block in ZOOKEEPER-2380 > Now shutdown is called from synchronized block from another place. > {code} > // check leader running status > if (!this.isRunning()) { > shutdown("Unexpected internal error"); > return; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)