[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860210#comment-15860210
 ] 

Michael Han commented on ZOOKEEPER-2683:
----------------------------------------

[~arshad.mohammad] Do you mind creating a pull request for this? It is easier 
to comment in github and easier to merge a PR with the merge script, thanks.

Quick comments on the patch: why not just do this instead?
{code}
assertTrue(
                "Leader failed to transition to new state. Current state is "
                        + leader.getServerState(),
            ClientBase.waitForServerState(leader, 15000,
                QuorumStats.Provider.LOOKING_STATE, 
QuorumStats.Provider.FOLLOWING_STATE,
                QuorumStats.Provider.LEADING_STATE));
{code}

> RaceConditionTest is flaky
> --------------------------
>
>                 Key: ZOOKEEPER-2683
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2683
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Mohammad Arshad
>            Assignee: Mohammad Arshad
>             Fix For: 3.5.3, 3.6.0
>
>         Attachments: ZOOKEEPER-2683-01.patch
>
>
> *Error Message*
> {noformat}
> Leader failed to transition to LOOKING or FOLLOWING state
> {noformat}
> *Stacktrace*
> {noformat}
> junit.framework.AssertionFailedError: Leader failed to transition to LOOKING 
> or FOLLOWING state
>       at 
> org.apache.zookeeper.server.quorum.RaceConditionTest.testRaceConditionBetweenLeaderAndAckRequestProcessor(RaceConditionTest.java:74)
>       at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
>       at java.util.concurrent.FutureTask.run(FutureTask.java:262)
>       at java.lang.Thread.run(Thread.java:745)
> {noformat}
> [CI Failures 
> Reference|https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/279//testReport/org.apache.zookeeper.server.quorum/RaceConditionTest/testRaceConditionBetweenLeaderAndAckRequestProcessor/]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to