[ https://issues.apache.org/jira/browse/ZOOKEEPER-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864328#comment-15864328 ]
ASF GitHub Bot commented on ZOOKEEPER-2672: ------------------------------------------- Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/168 The question is why these PRs not get closed automatically. A little bit investigation indicates a consistent pattern that PRs not closed were most committed by @rakeshadr :). Rakesh, any idea on why your commits didn't close PR? Were you using the merge script? > Remove CHANGE.txt > ----------------- > > Key: ZOOKEEPER-2672 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2672 > Project: ZooKeeper > Issue Type: Improvement > Components: build > Affects Versions: 3.4.9, 3.5.2 > Reporter: Michael Han > Assignee: Michael Han > Fix For: 3.4.10, 3.5.3, 3.6.0 > > > The CHANGE.txt is already not the source of truth of what's changed after we > migrating to git - most of the git commits in recent couple of months don't > update CHANGE.txt. The option of updating CHANGE.txt during commit flow > automatically is none trivial, and do that manually is cumbersome and error > prone. > The consensus is we would rely on source control revision logs instead of > CHANGE.txt moving forward; see > https://www.mail-archive.com/dev@zookeeper.apache.org/msg37108.html for more > details. -- This message was sent by Atlassian JIRA (v6.3.15#6346)