Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101836721
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -479,7 +479,7 @@ private boolean checkFourLetterWord(final SelectionKey
k, final int len)
// We take advantage of the limited size of the length to look
// for cmds. They are all 4-bytes which fits inside of an int
String cmd = FourLetterCommands.getCmdMapView().get(len);
- if (cmd == null) {
+ if (cmd == null ||
!FourLetterCommands.getWhiteListedCmdView().contains(cmd)) {
--- End diff --
What do you suggest it can be done here?
Maybe throw an exception if
``!FourLetterCommands.getWhiteListedCmdView().contains(cmd)`` is ``true`` and
get it in the callee?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
