[
https://issues.apache.org/jira/browse/ZOOKEEPER-2700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874599#comment-15874599
]
ASF GitHub Bot commented on ZOOKEEPER-2700:
-------------------------------------------
Github user flier commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r102028465
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -126,6 +125,9 @@
private final ZooKeeperServerListener listener;
private ZooKeeperServerShutdownHandler zkShutdownHandler;
+ private volatile long lastSnapshotZxid;
+ private AtomicInteger isGeneratingSnapshot = new AtomicInteger(0);
--- End diff --
In fact, I'm not sure whether Zookeeper backend threads will take snapshot
in parallel. So, I choose to use a `AtomicInteger` to protect manual call
`takeSnapshot`.
> Force ZooKeeper to generate snapshot
> ------------------------------------
>
> Key: ZOOKEEPER-2700
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2700
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Flier Lu
> Priority: Minor
>
> When cold backup or remote offline sync Zookeeper instances, we need the
> latest snapshot.
> Add a four letter `snap` command to force Zookeeper to generate snapshot.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
