Github user arshadmohammad commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/179#discussion_r104198451
  
    --- Diff: src/java/test/org/apache/zookeeper/ZKTestCase.java ---
    @@ -51,6 +51,12 @@ public void starting(FrameworkMethod method) {
                 // accidentally attempting to start multiple admin servers on 
the
                 // same port.
                 System.setProperty("zookeeper.admin.enableServer", "false");
    +            // ZOOKEEPER-2693 disables all 4lw by default.
    +            // Here we enable the 4lw which ZooKeeper tests depends.
    +            System.setProperty("zookeeper.4lw.commands.whitelist",
    +                    "ruok, envi, conf, stat, srvr, cons, dump," +
    --- End diff --
    
    ZKTestCase is base test class, covering a test scenario from this class 
should be avoided. May be you can add more test case in 
FourLetterWordsWhiteListTest to increase the coverage.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to