GitHub user joshelser opened a pull request:
https://github.com/apache/zookeeper/pull/186
ZOOKEEPER-2711 Avoid synchronization on NettyServerCnxn in Factory
NettyServerCnxnFactory previously synchronized on the (Netty)ServerCnxn
object to provide mutual exclusion at the RPC layer. However, this was
at odds with the synchronized methods in ServerCnxn (which shared the
same monitor). As such, it was possible to deadlock between concurrent
4LW commands that were invoking one of these synchronized methods
on ServerCnxn.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joshelser/zookeeper 2711-4lw
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/186.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #186
----
commit 9953e32963e6167f88b97519233b0872cce69a71
Author: Josh Elser <[email protected]>
Date: 2017-03-07T21:03:57Z
ZOOKEEPER-2711 Avoid synchronization on NettyServerCnxn in Factory
NettyServerCnxnFactory previously synchronized on the (Netty)ServerCnxn
object to provide mutual exclusion at the RPC layer. However, this was
at odds with the synchronized methods in ServerCnxn (which shared the
same monitor). As such, it was possible to deadlock between concurrent
4LW commands that were invoking one of these synchronized methods
on ServerCnxn.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
