[
https://issues.apache.org/jira/browse/ZOOKEEPER-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928570#comment-15928570
]
ASF GitHub Bot commented on ZOOKEEPER-2722:
-------------------------------------------
Github user skamille commented on the issue:
https://github.com/apache/zookeeper/pull/191
> ConnectionLossException can happen after a connection between ZooKeeper
client and server has been established, right? So having the check only in
watcher is not enough. A pass in watcher does not guarantee
ConnectionLossException will not occur in a later point in time. Imagine an
extreme case where the a network partition happened between client / server
after a session establishment - the client will first get a connected event,
and watcher happily reports everything is fine, then subsequent operation (e.g.
create) will fail with ConnectionLossException until the network healed.
Right but we're talking about a test case. If we have the issue that our
tests can connect to ZK, then randomly drop connections while in the midst of
the testing, that feels like a problem we should figure out. It should not
happen, and we rely on this particular "watch till connection then proceed with
test" functionality in tests throughout the code base. The fact that it is only
failing here seems to me a stranger problem. I'm supportive of adding more
logging to see if we can debug it.
> Flaky Test:
> org.apache.zookeeper.test.ReadOnlyModeTest.testSessionEstablishment
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2722
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.4.9, 3.5.2
> Reporter: Michael Han
> Assignee: Michael Han
> Labels: flaky, flaky-build, flaky-test
> Fix For: 3.5.3, 3.6.0
>
>
> {noformat}
> Error Message
> KeeperErrorCode = ConnectionLoss for /test
> Stacktrace
> org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode
> = ConnectionLoss for /test
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:99)
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:1423)
> at
> org.apache.zookeeper.test.ReadOnlyModeTest.testSessionEstablishment(ReadOnlyModeTest.java:238)
> at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Looks like we should retry before giving up.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
