[ https://issues.apache.org/jira/browse/ZOOKEEPER-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930853#comment-15930853 ]
ASF GitHub Bot commented on ZOOKEEPER-2725: ------------------------------------------- Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/195#discussion_r106759077 --- Diff: src/java/test/org/apache/zookeeper/server/MultiOpSessionUpgradeTest.java --- @@ -0,0 +1,87 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.zookeeper.server; + +import org.apache.zookeeper.CreateMode; +import org.apache.zookeeper.KeeperException; +import org.apache.zookeeper.Op; +import org.apache.zookeeper.OpResult; +import org.apache.zookeeper.ZooDefs; +import org.apache.zookeeper.ZooKeeper; +import org.apache.zookeeper.test.ClientBase; +import org.apache.zookeeper.test.QuorumBase; +import org.junit.Assert; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.Arrays; +import java.util.List; + +public class MultiOpSessionUpgradeTest extends QuorumBase { --- End diff -- Would it be possible to test `public Request checkUpgradeSession(Request request)` directly in addition to this integration style test? > Upgrading to a global session fails with a multiop > -------------------------------------------------- > > Key: ZOOKEEPER-2725 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2725 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.5.2 > Reporter: Brian Nixon > > On an ensemble with local sessions enabled, when a client with a local > session requests the creation of an ephemeral node within a multi-op, the > client gets a session expired message. The same multi-op works if the > session is already global. This breaks the client's expectation of seamless > promotion from local session to global session server-side. -- This message was sent by Atlassian JIRA (v6.3.15#6346)