Thanks a lot Pat for the feedback. I will prepare another release candidate, today(IST).
Thanks, Rakesh On Thu, Mar 23, 2017 at 12:33 AM, Patrick Hunt <ph...@apache.org> wrote: > FYI I just tested the latest branch 3.4 which includes the fix for 2712 and > the tests all passed. Kudos! > > Patrick > > On Wed, Mar 8, 2017 at 9:11 PM, Rakesh Radhakrishnan <rake...@apache.org> > wrote: > > > Thank you Pat and Michael for voting and comments. We are *not* releasing > > this candidate. > > > > Need to fix MiniKdc test failures. > > https://issues.apache.org/jira/browse/ZOOKEEPER-2712 > > > > I'll create another candidate once this is fixed. > > > > > > Rakesh > > > > On Thu, Mar 9, 2017 at 12:08 AM, Michael Han <h...@cloudera.com> wrote: > > > > > I am -1 on this one as well. > > > > > > I think we have had bad build > > > <https://builds.apache.org/job/ZooKeeper_branch34_jdk7/> for > branch-3.4 > > > for > > > a while. > > > These tests consistently fail after build 1423: > > > > > > > > > - > > > org.apache.zookeeper.server.quorum.auth.QuorumKerberosHostB > > > asedAuthTest.testValidCredentials > > > <https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1434 > > > /testReport/junit/org.apache.zookeeper.server.quorum.auth/Q > > > uorumKerberosHostBasedAuthTest/testValidCredentials/> > > > - > > > org.apache.zookeeper.server.quorum.auth.QuorumKerberosHostB > > > asedAuthTest.testConnectBadServer > > > <https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1434 > > > /testReport/junit/org.apache.zookeeper.server.quorum.auth/Q > > > uorumKerberosHostBasedAuthTest/testConnectBadServer/> > > > - > > > org.apache.zookeeper.server.quorum.auth.QuorumKerberosAuthT > > > est.testValidCredentials > > > <https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1434 > > > /testReport/junit/org.apache.zookeeper.server.quorum.auth/Q > > > uorumKerberosAuthTest/testValidCredentials/> > > > > > > > > > A brief look up indicates commit b26eaf3492a43821f648d8a8f87d8a > > c3488f1cef > > > <https://github.com/apache/zookeeper/commit/b26eaf3492a43821 > > > f648d8a8f87d8ac3488f1cef> > > > might be the culprit. > > > I think these tests need to be green before we can cut another RC > build. > > > > > > > > > On Wed, Mar 8, 2017 at 8:59 AM, Patrick Hunt <ph...@apache.org> wrote: > > > > > > > -1 - I'm seeing this test fail consistently on my Mac (the other > tests > > > all > > > > seem to be passing on the java side) > > > > > > > > Lots of the "server not up" messages followed by: > > > > > > > > 2017-03-08 08:54:58,507 [myid:] - INFO [Thread-1:FourLetterWordMain@ > > 62] > > > - > > > > connecting to 127.0.0.1 11224 > > > > 2017-03-08 08:54:58,508 [myid:] - INFO [Thread-1:ClientBase@245] - > > > server > > > > 127.0.0.1:11224 not up java.net.ConnectException: Connection refused > > > > (Connection refused) > > > > 2017-03-08 08:54:58,508 [myid:] - INFO > > > > [Thread-1:JUnit4ZKTestRunner$LoggedInvokeMethod@74] - TEST METHOD > > > FAILED > > > > testValidCredentials > > > > java.lang.AssertionError: waiting for server 1 being up > > > > > > > > > > > > On Wed, Mar 8, 2017 at 3:09 AM, Rakesh Radhakrishnan < > > rake...@apache.org > > > > > > > > wrote: > > > > > > > > > This is a bug fix release candidate for 3.4.10. It fixes 39 issues, > > > > > including > > > > > security feature QuorumPeer mutual authentication via SASL and > other > > > > > potential bugs. > > > > > > > > > > The full release notes are available at: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > > > > projectId=12310801&version=12338036 > > > > > > > > > > *** Please download, test and vote by March 14th 2017, 23:59 UTC+0. > > *** > > > > > > > > > > Source files: > > > > > http://people.apache.org/~rakeshr/zookeeper-3.4.10-candidate-0/ > > > > > > > > > > Maven staging repo: > > > > > https://repository.apache.org/content/groups/staging/org/ > > > > > apache/zookeeper/zookeeper/3.4.10/ > > > > > > > > > > The release candidate tag in git to be voted upon: > release-3.4.10-rc0 > > > > > https://github.com/apache/zookeeper/tree/release-3.4.10-rc0 > > > > > > > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the > release: > > > > > http://www.apache.org/dist/zookeeper/KEYS > > > > > > > > > > Should we release this candidate? > > > > > > > > > > > > > > > Rakesh > > > > > > > > > > > > > > > > > > > > > -- > > > Cheers > > > Michael. > > > > > >
