Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/208#discussion_r108231907
--- Diff:
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -84,4 +98,78 @@ public void testSendCloseSession() throws Exception {
zk.close();
}
}
+
+ @Test(timeout = 30000)
+ public void testMaxClientConnectionsReached() throws Exception {
+ final int maxClientCnxns = 4;
+ final int numClients = 10;
+ createAndTestConnections(numClients, maxClientCnxns,
maxClientCnxns);
+ }
+
+ @Test(timeout = 30000)
+ public void testMaxClientConnectionsDisabled() throws Exception {
+ final int maxClientCnxns = 0; // disabled cnxns limit
+ final int numClients = 10;
+ createAndTestConnections(numClients, maxClientCnxns, numClients);
+ }
+
+ private void createAndTestConnections(int numClients, int
maxClientCnxns, int cnxnsAccepted) throws Exception {
+
+ File tmpDir = ClientBase.createTmpDir();
+ final int CLIENT_PORT = PortAssignment.unique();
+
+ ZooKeeperServer zks = new ZooKeeperServer(tmpDir, tmpDir, 3000);
--- End diff --
it seems strange to me to have some tests that start their on zookeeper
server and another which uses the one provided by the @before from the
superclass. I think we should pick one approach per test class. What do you
think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
