Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/211#discussion_r110082136 --- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java --- @@ -87,6 +87,12 @@ public void close() { LOG.debug("close called for sessionid:0x" + Long.toHexString(sessionId)); } + + // ZOOKEEPER-2743: + // Always unregister connection upon close to prevent + // connection bean leak under certain race conditions. + factory.unregisterConnection(this); --- End diff -- Also it is guaranteed that the close call will be called at least once after the cnx bean is registered (e.g. when sever shutdown, the factor will iterate every cnx and close it..).
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---