Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110227948
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -216,18 +218,35 @@ public boolean isQuorumSynced(QuorumVerifier qv) {
private final ServerSocket ss;
- Leader(QuorumPeer self,LeaderZooKeeperServer zk) throws IOException {
+ Leader(QuorumPeer self,LeaderZooKeeperServer zk) throws IOException,
X509Exception {
this.self = self;
try {
- if (self.getQuorumListenOnAllIPs()) {
- ss = new ServerSocket(self.getQuorumAddress().getPort());
+ if (self.shouldUsePortUnification()) {
--- End diff --
This is a tough call IMO. I think you are correct that moving this out of
the Leader would make the leader code simpler but on the other hand this is
logic that I think "belongs" to the leader and is not really relevant anywhere
else.
What do you think about the compromise of moving this to a static method in
Leader where it can be tested and prevents cluttering up the constructor logic?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
