[
https://issues.apache.org/jira/browse/ZOOKEEPER-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960216#comment-15960216
]
Hadoop QA commented on ZOOKEEPER-2729:
--------------------------------------
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 95 new Findbugs (version
3.0.1) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/517//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/517//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/517//console
This message is automatically generated.
> Cleanup findbug warnings in branch-3.4: Correctness Warnings
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-2729
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2729
> Project: ZooKeeper
> Issue Type: Sub-task
> Affects Versions: 3.4.9
> Reporter: Rakesh R
> Assignee: Abraham Fine
> Fix For: 3.4.11
>
>
> {code}
> (1) INT Bad comparison of nonnegative value with 0 in
> org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthLearner.send(DataOutputStream,
> byte[])
> Bug type INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE (click for details)
> In class org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthLearner
> In method
> org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthLearner.send(DataOutputStream,
> byte[])
> Value 0
> At SaslQuorumAuthLearner.java:[line 176]
> (2) INT Bad comparison of nonnegative value with 0 in
> org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthServer.send(DataOutputStream,
> byte[], QuorumAuth$Status)
> Bug type INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE (click for details)
> In class org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthServer
> In method
> org.apache.zookeeper.server.quorum.auth.SaslQuorumAuthServer.send(DataOutputStream,
> byte[], QuorumAuth$Status)
> Value 0
> At SaslQuorumAuthServer.java:[line 170]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
