[
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986361#comment-15986361
]
Hadoop QA commented on ZOOKEEPER-2662:
--------------------------------------
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/645//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/645//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/645//console
This message is automatically generated.
> Export a metric for txn log sync times
> --------------------------------------
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync
> the txn log in order to warn if that time exceeds a configurable threshold.
> This information should also be exported as a metric available by JMX so an
> important aspect of quorum performance can be monitored.
> ZooKeeperServerMXBean carries some global latency information for the server
> process already, seems like a good place to put it if not an entirely new
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same
> information for snapshots.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
