[ https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988645#comment-15988645 ]
Hadoop QA commented on ZOOKEEPER-2697: -------------------------------------- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/658//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/658//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/658//console This message is automatically generated. > Handle graceful stop of ZookKeeper client > ----------------------------------------- > > Key: ZOOKEEPER-2697 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2697 > Project: ZooKeeper > Issue Type: Improvement > Components: java client > Affects Versions: 3.4.9 > Reporter: Enrico Olivelli > Priority: Critical > > As seen in ZOOKEEPER-1394 I would like to have the "close" which waits for > all background activities to finish. > In tests the method "testableWaitForShutdown" is used. > We can add a new ZooKeeper.close(int tineout) method which will act as > testableWaitForShutdown, joining all support threads. -- This message was sent by Atlassian JIRA (v6.3.15#6346)