Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114166007
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -254,6 +260,9 @@ protected void connectToLeader(InetSocketAddress addr)
}
sockConnect(sock, addr, Math.min(self.tickTime *
self.syncLimit, remainingInitLimitTime));
+ if (self.isSslQuorum()) {
+ ((SSLSocket) sock).startHandshake();
+ }
sock.setTcpNoDelay(nodelay);
break;
} catch (IOException e) {
--- End diff --
Is it possible to get a more typed exception here (like SSLException) when
hand shake failed? This serves several purposes: if we know the SSL cert is
invalid there is no point retrying; from supportability point of view when hand
shake failed, it's possible that what finally gets logged does not reflect the
cause of the failure due to how these exceptions are handled (for example we
may see in log that initLimit was exceeded while the real culprit is invalid
cert).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
