[jira] [Commented] (ZOOKEEPER-2767) Correct the exception messages in X509Util if truststore location or password is not configured

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992510#comment-15992510
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2767:
-------------------------------------------

GitHub user ramu11 opened a pull request:

    https://github.com/apache/zookeeper/pull/246

     Corrected keystore related messages to truststore messages for trust…

    possible fix for "https://issues.apache.org/jira/browse/ZOOKEEPER-2767";

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ramu11/zookeeper ZOOKEEPER-2767

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #246
    
----
commit a76636465022f646ac4f7b8f3827666918b2c1bf
Author: Kodanda Ramu Kakarla <kkaka...@kkakarla.pnq.csb>
Date:   2017-05-02T07:56:10Z

     Corrected keystore related messages to truststore messages for truststore 
location/password checks

----


> Correct the exception messages in X509Util if truststore location or password 
> is not configured
> -----------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2767
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2767
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: java client, server
>    Affects Versions: 3.5.4, 3.6.0
>            Reporter: Abhishek Kumar
>            Priority: Trivial
>
> In 
> org.apache.zookeeper.common.X509Util.org.apache.zookeeper.common.X509Util.createSSLContext
>  exception messages contains keystore related messages instead of truststore 
> messages for truststore location/password checks:
> {noformat}
> if (trustStoreLocationProp == null && trustStorePasswordProp == null) {
>             LOG.warn("keystore not specified for client connection");
>         } else {
>             if (trustStoreLocationProp == null) {
>                 throw new SSLContextException("keystore location not 
> specified for client connection");
>             }
>             if (trustStorePasswordProp == null) {
>                 throw new SSLContextException("keystore password not 
> specified for client connection");
>             }
>             try {
>                 trustManagers = new TrustManager[]{
>                         createTrustManager(trustStoreLocationProp, 
> trustStorePasswordProp)};
>             } catch (TrustManagerException e) {
>                 throw new SSLContextException("Failed to create KeyManager", 
> e);
>             }
>         }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)